Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ansible-lint: disable for python2 #80911

Merged
merged 1 commit into from Feb 25, 2020
Merged

pythonPackages.ansible-lint: disable for python2 #80911

merged 1 commit into from Feb 25, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 23, 2020 •
edited

Motivation for this change

noticed it was broken reviewing another package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from sengaya February 23, 2020 21:03
@jonringer
pythonPackages.ansible-lint: disable for python2
e712ed1 
raumel.yaml is not importable, which makes pip
fail during installation
@jonringer jonringer changed the title pythonPackages.ansible-lint: disable check on python2 pythonPackages.ansible-lint: disable for python2 Feb 23, 2020
@jonringer
Copy link
Contributor Author

going to merge this after 24 hours, if no one has any protest. build is broken on master

sengaya
sengaya approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@sengaya sengaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, locally tested on MacOS

@jonringer jonringer merged commit e1e71e5 into NixOS:master Feb 25, 2020
@jonringer jonringer deleted the disable-checks-python2 branch February 25, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sengaya sengaya sengaya approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @sengaya