Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Improved road tunnel construction gui icons #5

Merged
merged 1 commit into from Feb 23, 2020

Conversation

Andrew350
Copy link
Contributor

This updates the road tunnel construction gui icons to match the "new" tunnel graphics added way back in 2013.

I'm using this as an excuse to try learning git, so apologies in advance for anything wrong. Honestly it's all a little over my head, sprites are so much easier!

LordAro
LordAro previously approved these changes Feb 22, 2020
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Perhaps the old sprites should be removed from the gui*.png images?

@Andrew350
Copy link
Contributor Author

I considered it, but it looks like the precedent has been to leave the original spritesheets alone and just make a new file with the new sprites, so I did it that way to follow suit.

The entire source is bloated by tons of duplicate/outdated/unused sprites which should probably be removed, but that is an issue for a different PR I think.

@TrueBrain
Copy link
Member

Would you mind rebasing your work to the latest version? That way the CI kicks in, and it is easier to validate your changes :) Tnx!

git remote add upstream https://github.com/OpenTTD/OpenGFX
git fetch upstream
git rebase upstream/master

@Andrew350
Copy link
Contributor Author

Had to re-install git and set everything up again, so hopefully everything's good!

@LordAro LordAro merged commit 80a20cb into OpenTTD:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants