Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poetry: 0.12.17 -> 1.0.3 #80819

Merged
merged 1 commit into from Feb 22, 2020
Merged

poetry: 0.12.17 -> 1.0.3 #80819

merged 1 commit into from Feb 22, 2020

Conversation

deingithub
Copy link
Contributor

Motivation for this change
  • ZHF: ZERO Hydra Failures 20.03 #80379
  • The current version is outdated by quite a bit and fails to build due to substituteInPlace'ing setup.py having no effect on the resulting wheel (anymore?)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" (exits with No diff detected, stopping review..., which I assume is good)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

relevant #77629 (comment)

@jonringer
Copy link
Contributor

still will be worthwhile to update this package though

@ofborg ofborg bot requested a review from jbaum98 February 22, 2020 19:14
jonringer
jonringer approved these changes Feb 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

https://github.com/NixOS/nixpkgs/pull/80819
3 package built:
python27Packages.poetry python37Packages.poetry python38Packages.poetry

@jonringer
Copy link
Contributor

jonringer commented Feb 22, 2020 •
edited

@GrahamcOfBorg build python27Packages.poetry python37Packages.poetry python38Packages.poetry

@jonringer
Copy link
Contributor

I guess since we moved the "poetry" builder to outside of python-modules, we avoided the "self-bootstrapping" that was required to progress on the package

@jonringer jonringer closed this Feb 22, 2020
@jonringer jonringer reopened this Feb 22, 2020
@jonringer jonringer merged commit df54d70 into NixOS:master Feb 22, 2020
@jonringer
Copy link
Contributor

accidently clicked wrong button :)

@deingithub deingithub mentioned this pull request Feb 22, 2020
Merged
10 tasks
@deingithub deingithub deleted the poetry-1 branch February 22, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jbaum98 jbaum98 Awaiting requested review from jbaum98

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deingithub @jonringer @Janik-Haag