Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/qt: extend #80866

Closed
wants to merge 4 commits into from
Closed

nixos/qt: extend #80866

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 23, 2020 •
edited by ghost

Motivation for this change

See #71079
Gtk part #80865

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested a review from infinisil as a code owner February 23, 2020 05:10
@ghost ghost mentioned this pull request Feb 23, 2020
Closed
10 tasks
@ghost ghost requested a review from worldofpeace February 23, 2020 05:51
@veprbl veprbl requested a review from ttuegel February 23, 2020 05:52
@bqv
Copy link
Contributor

bqv commented Mar 22, 2020

@worldofpeace @ttuegel ping

ttuegel
ttuegel approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

worldofpeace
worldofpeace suggested changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to request changes

@ghost
Copy link
Author

ghost commented Apr 1, 2020

@worldofpeace Fixed, thank you!

@ghost ghost requested a review from worldofpeace April 11, 2020 06:55
@colemickens colemickens mentioned this pull request Apr 30, 2020
Closed
@ghost ghost requested a review from ttuegel May 12, 2020 11:48
@ghost ghost closed this Jul 3, 2020
@ghost ghost deleted the qt-theming branch July 3, 2020 19:02
@ghost ghost removed request for ttuegel, infinisil and worldofpeace July 3, 2020 19:03
@quantenzitrone
Copy link
Contributor

yo what happened to this?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bqv @quantenzitrone @ttuegel @worldofpeace