dua: 2.1.11 -> 2.3.1 #80777
Merged
dua: 2.1.11 -> 2.3.1 #80777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killercup
reviewed
Feb 24, 2020
There was a problem hiding this comment.
Tested and confirmed working on NixOS. For macOS it says
builder for '/nix/store/jlr979znfyxyiwrfrbijbs6w4kbrqwl1-dua-2.3.1.drv' failed with exit code 1; last 10 log lines:
unpacking sources
unpacking source archive /nix/store/27kbk099g60x55p80bz0r52gcg60z5p0-source
source root is source
unpacking source archive /nix/store/wxzi4fxpwnkvcnjvy38vxhp92rdcky1v-dua-2.3.1-vendor.tar.gz
dyld: Library not loaded: @rpath/CoreFoundation.framework/Versions/A/CoreFoundation
Referenced from: /nix/store/01fyi95rmqzc3r1pfjaqfj0xaw3r9c2c-gettext-0.20.1/lib/libintl.8.dylib
Reason: no suitable image found. Did find:
/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation: file system sandbox blocked stat()
/nix/store/wzarnmaz33i8qx9n858whzdkp6wfw9pr-stdenv-darwin/setup: line 840: 15020 Abort trap: 6 tar xf "$fn"
but that might be a problem on my machine.
|
@killercup are you OK with disabling the tests? |
Yeah, that's fine. As far as I can tell a lot of them depend on the fixtures that mess up the checksum thanks to weird unicode support in some filesystems. |
|
Thanks for the review(s)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
https://github.com/Byron/dua-cli#-v22-show-size-on-disk-by-default-dependency-update
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)