New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pythonPackages.seaborn: use v0.9.1 for python 2 #80832
Conversation
required for poretools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
commit LGTM
[4 built, 1 copied (134.2 MiB), 61.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80832
2 package built:
poretools python27Packages.seaborn
@GrahamcOfBorg build poretools python27Packages.seaborn |
description = "Statisitical data visualization"; | ||
homepage = "http://stanford.edu/~mwaskom/software/seaborn/"; | ||
license = with lib.licenses; [ bsd3 ]; | ||
maintainers = with lib.maintainers; [ fridh ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except I won't be maintaining a Python 2 version ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops :) Should I remove you from maintainers in new PR or in backport?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done: #80882 (and added to backport).
Motivation for this change
required for poretools
ZHF: #80379
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)