Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: realsprites animated flag for various features, suppressing spurious warnings #31

Merged
merged 14 commits into from Feb 23, 2020

Conversation

andythenorth
Copy link
Contributor

@andythenorth andythenorth commented Feb 23, 2020

This relates to sprites that use palette cycle animation, and sets the realsprite ANIM flag appropriately for nml.

  • water features
  • level crossings
  • airport runway markers
  • explosions
  • parks and fountains
  • town buildings
  • industries
  • Toyland cola truck
  • UFOs
  • the bizarre toyland statue with animated eyes, frosch promotes keeping as easter egg

I've applied these broadly. I have checked many sprites individually, but for e.g. water, I've set the flag everywhere for entire spritesheets, life is far too short to check every pixel in every sprite.

Also fixed any minor obvious incorrect use of animated pixels

  • CS2400 engine
  • Toyland ships
  • sprite 1551 office building
  • sprites 4617..4619 skyscraper

Also removed animated pixels that were TMWFTLB to set the flag for

  • Ploddyphut engine

The remaining warnings are valid IMO.

@andythenorth andythenorth marked this pull request as ready for review February 23, 2020 19:39
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be honest, I only read the first few lines. But it builds, so I trust you :p

@andythenorth andythenorth merged commit af0a84b into OpenTTD:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants