New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: realsprites animated flag for various features, suppressing spurious warnings #31
Merged
andythenorth
merged 14 commits into
OpenTTD:master
from
andythenorth:fix-animated-sprite-warnings
Feb 23, 2020
Merged
Fix: realsprites animated flag for various features, suppressing spurious warnings #31
andythenorth
merged 14 commits into
OpenTTD:master
from
andythenorth:fix-animated-sprite-warnings
Feb 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andythenorth
force-pushed
the
fix-animated-sprite-warnings
branch
from
February 23, 2020 18:04
485e272
to
f9b7371
Compare
…sing spurious warnings
andythenorth
force-pushed
the
fix-animated-sprite-warnings
branch
from
February 23, 2020 18:26
f67acfc
to
26e772f
Compare
…ng spurious warnings
…ut engine, TWMWFTLB to set the ANIM flag as the realsprites are templated and nothing else uses ANIM
…g spurious warnings
…ng spurious warning
andythenorth
force-pushed
the
fix-animated-sprite-warnings
branch
from
February 23, 2020 21:09
f25385b
to
a0c424e
Compare
LordAro
approved these changes
Feb 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll be honest, I only read the first few lines. But it builds, so I trust you :p
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to sprites that use palette cycle animation, and sets the realsprite ANIM flag appropriately for nml.
I've applied these broadly. I have checked many sprites individually, but for e.g. water, I've set the flag everywhere for entire spritesheets, life is far too short to check every pixel in every sprite.
Also fixed any minor obvious incorrect use of animated pixels
Also removed animated pixels that were TMWFTLB to set the flag for
The remaining warnings are valid IMO.