Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netpbm: fix typo on substituteInPlace parameters #80802

Merged
merged 1 commit into from Feb 22, 2020
Merged

netpbm: fix typo on substituteInPlace parameters #80802

merged 1 commit into from Feb 22, 2020

Conversation

andir
Copy link
Member

@andir andir commented Feb 22, 2020

Motivation for this change

It seems like originally -dSAFER should have been replaced with
-dPARANOIDSAFER instead of -DSAFER (capital D vs lower case d).

This was pointed out in #75153 (cc @caadar @veprbl). This might now finally (properly?) fix
CVE-2005-2471.

cc @vcunat as you initially added that substitution.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andir
netpbm: fix typo on substituteInPlace parameters
8e08f75 
It seems like originally `-dSAFER` should have been replaced with
`-dPARANOIDSAFER` instead of `-DSAFER` (capital D vs lower case d).

This was pointed out in NixOS#75153. This might now finally (properly?) fix
CVE-2005-2471.
@vcunat vcunat merged commit d7266d0 into NixOS:master Feb 22, 2020
vcunat added a commit that referenced this pull request Feb 22, 2020
@vcunat
Merge #80802: netpbm: fix typo on substituteInPlace parameters
2a810eb 
(cherry picked from commit d7266d0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andir @vcunat