Fix: [Makefile] make sure that filenames in the tarball are as OpenTTD expects #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…D expects It looks for readme.txt, license.txt and changelog.txt by name. So no matter how we call it in the repository, make sure it matches with the expectation in the tarball.
LordAro
approved these changes
Feb 23, 2020
matthijskooijman
added a commit
to matthijskooijman/OpenGFX
that referenced
this pull request
May 12, 2020
It looks for readme.txt, license.txt and changelog.txt by name. So no matter how we call it in the repository, make sure it matches with the expectation in the installed directory. This fix was already applied for the tarball in PR OpenTTD#24, but that missed the filenames used when installing into the filesystem directly. See also issue OpenTTD#22.
LordAro
pushed a commit
that referenced
this pull request
Jan 1, 2021
It looks for readme.txt, license.txt and changelog.txt by name. So no matter how we call it in the repository, make sure it matches with the expectation in the installed directory. This fix was already applied for the tarball in PR #24, but that missed the filenames used when installing into the filesystem directly. See also issue #22.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks for readme.txt, license.txt and changelog.txt by name. So
no matter how we call it in the repository, make sure it matches
with the expectation in the tarball.
Fixes #22