Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] pythonPackages.ldaptor: fix build #80877

Merged
merged 1 commit into from Feb 23, 2020
Merged

[20.03] pythonPackages.ldaptor: fix build #80877

merged 1 commit into from Feb 23, 2020

Conversation

maxxk
Copy link
Contributor

@maxxk maxxk commented Feb 23, 2020

(cherry picked from commit 50f3704)

Motivation for this change

Backports #80834
ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@maxxk
pythonPackages.ldaptor: fix build
ccf915c 
(cherry picked from commit 50f3704)
@maxxk maxxk changed the title pythonPackages.ldaptor: fix build [20.03] pythonPackages.ldaptor: fix build Feb 23, 2020
jonringer
jonringer approved these changes Feb 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

[2 built, 70 copied (316.5 MiB), 68.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80877
1 package built:
python27Packages.ldaptor

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python27Packages.ldaptor

@jonringer jonringer merged commit 25d1554 into NixOS:release-20.03 Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxxk @jonringer