Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wayvnc, neatvnc: init at 0.1.0 #80902

Merged
merged 3 commits into from Feb 29, 2020
Merged

wayvnc, neatvnc: init at 0.1.0 #80902

merged 3 commits into from Feb 29, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Feb 23, 2020 •
edited

Motivation for this change

Status: Theoretically it should work, but unfortunately wayvnc does crash inside my test VM after receiving SIGILL. Details regarding my crash are here: any1/neatvnc#21
Works, but if we don't override the default configuration it requires AVX on x86_64 CPUs.
I decided to disable the usage of CPU extensions for performance by default (should be appropriate for Nixpkgs).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos primeos changed the title [WIP] wayvnc, neatvnc: init at 0.1.0 wayvnc, neatvnc: init at 0.1.0 Feb 23, 2020
@primeos
neatvnc: Disable the CPU acceleration by default
c1e7726 
For Nixpkgs it seems best to disable the usage of CPU extensions by
default as older CPUs don't support them which will result in a crash at
runtime (SIGILL: Illegal instruction) [0].
The performance on my old test system was more than enough anyway
(usually ~10% CPU usage due to wayvnc).

[0]: any1/neatvnc#21
@primeos primeos merged commit 6ec8687 into NixOS:master Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@primeos