Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dune_2: fix hash #80809

Merged
merged 1 commit into from Feb 24, 2020
Merged

dune_2: fix hash #80809

merged 1 commit into from Feb 24, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Feb 22, 2020

Motivation for this change

upstream retagged 2.3.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from vbgl February 22, 2020 16:03
@marsam
Copy link
Contributor Author

marsam commented Feb 23, 2020

Upstream retagged 2.3.1 again, and now it does not build:

nix-build -A dune_2
these derivations will be built:
  /nix/store/bq120hpmmvai4xqf73xqf3pk4r9bchcn-dune-2.3.1.drv
building '/nix/store/bq120hpmmvai4xqf73xqf3pk4r9bchcn-dune-2.3.1.drv'...
⋮
./.duneboot.exe
Done: 53/647 (jobs: 8)cd _boot && /nix/store/vvhkf305m0ivsxrm645f7lx87x93f7z1-ocaml-4.07.1/bin/ocamlopt.opt -c -g -I +threads fcntl_stubs.c
clang-7: warning: argument unused during compilation: '-fno-strict-overflow' [-Wunused-command-line-argument]
Done: 449/647 (jobs: 8)cd _boot && /nix/store/vvhkf305m0ivsxrm645f7lx87x93f7z1-ocaml-4.07.1/bin/ocamlopt.opt -c -g -no-alias-deps -w -49 -pp ./pp/pp.exe -dump-ast -I +threads dune__module_name.ml
File "src/dune/module_name.ml", line 101, characters 10-23:
Error: Unbound value of_string_opt
make: *** [Makefile:30: dune.exe] Error 2
builder for '/nix/store/bq120hpmmvai4xqf73xqf3pk4r9bchcn-dune-2.3.1.drv' failed with exit code 2
error: build of '/nix/store/bq120hpmmvai4xqf73xqf3pk4r9bchcn-dune-2.3.1.drv' failed

@vbgl
Copy link
Contributor

vbgl commented Feb 24, 2020

What about fixing the URL to the commit that used to be tagged as 2.3.1?

@marsam
Copy link
Contributor Author

marsam commented Feb 24, 2020

Updated to the latest hash

What about fixing the URL to the commit that used to be tagged as 2.3.1?

we use the released tbz, which replaces %%VERSION%% accordingly.

@vbgl
Copy link
Contributor

vbgl commented Feb 24, 2020

@GrahamcOfBorg build ocamlPackages.dune-configurator

@vbgl vbgl merged commit 2e1198c into NixOS:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vbgl vbgl Awaiting requested review from vbgl

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @vbgl