New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breezy: init at 3.0.2 #80808
breezy: init at 3.0.2 #80808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the lazr packages are PEP420 compliant, but it might be useful to do a pythonImportsCheck = [ "lazr.package" ];
just to ensure that a package isn't exporting a rogue __init__.py
I've added it to |
i would do:
it should show you the file it imported (if there is one), this file will need to be removed for the pep420 namespacing to work correctly it will say something like |
after more investigating, it's because #80595 hasn't found it's way into master yet The pythonImportsCheck phase will run before setuptoolsCheckPhase, which means that the PWD will be set to $out, thus setup.py will not be present |
for now, I would just do the |
Updated. Thank you for explain it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonringer, if it's good for you I'd say it's ready to be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80808
10 package built:
breezy python37Packages.launchpadlib python37Packages.lazr-restfulclient python37Packages.lazr-uri python37Packages.wadllib python38Packages.breezy python38Packages.launchpadlib python38Packages.lazr-restfulclient python38Packages.lazr-uri python38Packages.wadllib
@GrahamcOfBorg build breezy |
@marsam Thank you! |
Motivation for this change
See #80740
cc: @rnhmjoj
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)