Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breezy: init at 3.0.2 #80808

Merged
merged 5 commits into from Feb 28, 2020
Merged

breezy: init at 3.0.2 #80808

merged 5 commits into from Feb 28, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Feb 22, 2020

Motivation for this change

See #80740
cc: @rnhmjoj

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the lazr packages are PEP420 compliant, but it might be useful to do a pythonImportsCheck = [ "lazr.package" ]; just to ensure that a package isn't exporting a rogue __init__.py

pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
@marsam
Copy link
Contributor Author

marsam commented Feb 23, 2020

but it might be useful to do a pythonImportsCheck = [ "lazr.package" ];

I've added it tolazr.restfulclient. I tried to add to lazr.uri, but it fails; I'm not sure why.

@jonringer
Copy link
Contributor

i would do:

$nix-shell ./nixpkgs/default.nix -A python3Packages.lazr-restfulclient
[nixshell] $ python
>>> import lazr
>>> lazr

it should show you the file it imported (if there is one), this file will need to be removed for the pep420 namespacing to work correctly

it will say something like <namespace> if it loaded correctly

@jonringer
Copy link
Contributor

jonringer commented Feb 24, 2020

after more investigating, it's because #80595 hasn't found it's way into master yet

The pythonImportsCheck phase will run before setuptoolsCheckPhase, which means that the PWD will be set to $out, thus setup.py will not be present

@jonringer
Copy link
Contributor

for now, I would just do the pythonImportsCheck on expressions that you're not testing. Eventually we will be able to do tests + pythonImportsCheck

@marsam
Copy link
Contributor Author

marsam commented Feb 24, 2020

Updated. Thank you for explain it

Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonringer, if it's good for you I'd say it's ready to be merged.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80808
10 package built:
breezy python37Packages.launchpadlib python37Packages.lazr-restfulclient python37Packages.lazr-uri python37Packages.wadllib python38Packages.breezy python38Packages.launchpadlib python38Packages.lazr-restfulclient python38Packages.lazr-uri python38Packages.wadllib

@jonringer
Copy link
Contributor

@GrahamcOfBorg build breezy

@jonringer jonringer merged commit 4e50a04 into NixOS:master Feb 28, 2020
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Feb 28, 2020

@marsam Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants