libfido2: add macOS support #80909
Merged
libfido2: add macOS support #80909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pass IOKit to libfido2 * Add a patch so that cmake uses lld flags when linking * Upgrade from 1.3.0 to 1.3.1 (based off NixOS#80781) * Specify CMAKE_INSTALL_LIBDIR so that the demo binaries link correctly on macOS and libfido2.pc specifies correct arguments
|
@GrahamcOfBorg build libfido2 |
|
The fix looks great! Will you upstream the patch to https://github.com/Yubico/libfido2 please? |
|
I'll want to find something more robust by testing supported compile flags before I upstream it. I'm currently just using "on a mac and using Clang" as a proxy for lld, which is not entirely accurate (except in the bounds of nixOS). |
prusnak
approved these changes
Feb 23, 2020
|
FTR the issue was just fixed in the upstream where it was reported by mmahut: Yubico/libfido2#127 |
|
Oh, thanks! I don't think it's worth it to make a new PR to switch to their official patch, but we can remove the patch when the next one releases. |
|
Agreed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Currently, libfido2 does not support building on macOS. This means that OpenSSH 8.2 will be unable to support ecdsa-sk keys on macOS when running as an SSH client.
Things done
correctly on macOS and libfido2.pc specifies correct arguments
I tested that FIDO keys were detected on both nixOS and macOS 10.13 (the newest mac I own).
I also built openssh 8.2p1 using the changes from #80196 with libfido2 and was able to generate an ecdsa-sk keypair on both nixOS and macOS.
Note that I do not have permission to build with ofborg on macOS, so someone else will have to do that for me.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)