New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various of minor stuff #21
Conversation
custom_tags.txt is a NML input file for custom tags in lang/english.lng |
c524192
to
ac99461
Compare
Makefile
Outdated
custom_tags.txt: Makefile.vcs | ||
$(_E) "[LNG] $@" | ||
$(_E) "[NML] $@" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why? NML is not invoked here, see line 317
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LNG made no sense what-so-ever to me. It might be that NML needs it for that, but in the context of this repo that is just confusing. NML was the closest I could think of, as it prepares a file for NML to use. Other suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "LNG" is not that bad. custom_tags.txt is an "include" for the .lng files.
ac99461
to
9f88422
Compare
While at it, parsetab.py is no longer left behind by NML.
…ed globally This list never ends. People keep finding local files to add for their specific editor, for their specific setup, etc. Please, learn to use the global git ignore, and lets keep these local gitignores for exactly that: local ignores.
9f88422
to
ddb2585
Compare
Over time a few things got left behind that appears to have no
function anymore. So let's remove them, and see if anyone notices.