Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.importlib-metadata: 1.3.0 -> 1.5.0 #80893

Merged
merged 1 commit into from Feb 24, 2020
Merged

pythonPackages.importlib-metadata: 1.3.0 -> 1.5.0 #80893

merged 1 commit into from Feb 24, 2020

Conversation

colemickens
Copy link
Member

Motivation for this change

Update importlib-metadata to latest (1.5.0).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@colemickens
Copy link
Member Author

I hit cancel mid-request, but didn't catch it, sorry -- this should be a draft, this is a WIP...

It currently does not work, this introduces infinite recursion when building this package.

error: while evaluating the attribute 'drvPath' at /home/cole/code/nixpkgs-importlibmetadata/lib/customisation.nix:158:7:
while evaluating the attribute 'nativeBuildInputs' of the derivation 'python2.7-importlib-metadata-1.5.0' at /home/cole/code/nixpkgs-importlibmetadata/pkgs/development/interpreters/python/mk-python-derivation.nix:105:3:
while evaluating the attribute 'out.outPath' at /home/cole/code/nixpkgs-importlibmetadata/lib/customisation.nix:151:13:
while evaluating the attribute 'nativeBuildInputs' of the derivation 'python2.7-pyfakefs-3.7.1' at /home/cole/code/nixpkgs-importlibmetadata/pkgs/development/interpreters/python/mk-python-derivation.nix:105:3:
while evaluating the attribute 'out.outPath' at /home/cole/code/nixpkgs-importlibmetadata/lib/customisation.nix:151:13:
while evaluating the attribute 'propagatedBuildInputs' of the derivation 'python2.7-pytest-4.6.8' at /home/cole/code/nixpkgs-importlibmetadata/pkgs/development/interpreters/python/mk-python-derivation.nix:105:3:
while evaluating the attribute 'out.outPath' at /home/cole/code/nixpkgs-importlibmetadata/lib/customisation.nix:151:13:
while evaluating the attribute 'propagatedBuildInputs' of the derivation 'python2.7-pluggy-0.13.1' at /home/cole/code/nixpkgs-importlibmetadata/pkgs/development/interpreters/python/mk-python-derivation.nix:105:3:
while evaluating the attribute 'out.outPath' at /home/cole/code/nixpkgs-importlibmetadata/lib/customisation.nix:151:13:
infinite recursion encountered, at undefined position

@colemickens
Copy link
Member Author

Note: python37Packages.importlib-metadata builds, but not 27,35,36 or 38 (I think 38 is expected, since this package is obsoleted by a builtin library in python3.8).

@colemickens
Copy link
Member Author

I couldn't quite figure out how to skip the test_main.py, which we might not need anyway, so I just deleted it to at least show it works (and unblock another branch of mine for now).

@jonringer
Copy link
Contributor

this rebuilds the majority of the python package set, please target staging

jonringer
jonringer reviewed Feb 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they just added pyfakefs as a checkInput, this is very do-able

pkgs/development/python-modules/importlib-metadata/default.nix Show resolved Hide resolved
pkgs/development/python-modules/importlib-metadata/default.nix Show resolved Hide resolved
@colemickens
Copy link
Member Author

Hi @jonringer. Thanks for looking. As for your suggestion - that's what I did at first, and it yielded the infinite recursion error that I posted. If you look at my two commits, you'll see one added the pyfakefs checkDep and then my workaround removed it again since it caused the inf recur error.

Obviously deleting the test is not ideal, but I don't know how to proceed with your recommendation without hitting the recursion error.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 10.rebuild-darwin-stdenv 10.rebuild-linux-stdenv labels Feb 23, 2020
@jonringer jonringer changed the base branch from master to staging February 23, 2020 23:54
@jonringer
Copy link
Contributor

I think deleting the test, and just noting that it's done to avoid infinite recursion is fine

@ofborg ofborg bot removed 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 10.rebuild-darwin-stdenv 10.rebuild-linux-stdenv labels Feb 24, 2020
jonringer
jonringer reviewed Feb 24, 2020
View reviewed changes
pkgs/development/python-modules/importlib-metadata/default.nix Outdated
Comment on lines 31 to 32
# removing test_main.py - it requires 'pyflakefs'
# and adding `pyflakefs` to `checkInputs` causes infinite recursion.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move the comments outside of the string, if we want to edit the comments later, the string comments will cause a rebuild, while nix comments will not

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thx. addressed and pushed already.

@colemickens
Copy link
Member Author

I was able to build (on nixos-unstable) for: python{27,35,36,37}Packages.importlib-metadata.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.importlib-metadata
@GrahamcOfBorg build python3Packages.importlib-metadata
@GrahamcOfBorg build python38Packages.importlib-metadata

@jonringer
Copy link
Contributor

darwin builds are timing out due to trying to rebuild llvm

@jonringer jonringer merged commit 2f893b5 into NixOS:staging Feb 24, 2020
@colemickens colemickens deleted the nixpkgs-importlibmetadata branch December 30, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@edolstra edolstra Awaiting requested review from edolstra

@infinisil infinisil Awaiting requested review from infinisil

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92

@Profpatsch Profpatsch Awaiting requested review from Profpatsch

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colemickens @jonringer