Fix: [Makefile] make sure 'make clean' cleans all generated files #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.dep files were left behind, as some other files were. Normally this would be fine, but there are cases where the generated .dep content is invalid. After that, normal users get stuck, as 'make clean' doesn't bring them back to a known-good-state. Now 'make clean' removes all generated files correctly, meaning the repository should be back to a known-good-state afterwards.
LordAro
approved these changes
Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.dep files were left behind, as some other files were. Normally
this would be fine, but there are cases where the generated .dep
content is invalid. After that, normal users get stuck, as
'make clean' doesn't bring them back to a known-good-state.
Now 'make clean' removes all generated files correctly, meaning
the repository should be back to a known-good-state afterwards.