Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netdata: 1.19.0 -> 1.20.0 #80831

Merged
merged 3 commits into from Feb 24, 2020
Merged

netdata: 1.19.0 -> 1.20.0 #80831

merged 3 commits into from Feb 24, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 22, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Feb 22, 2020

@GrahamcOfBorg build netdata

@Mic92 Mic92 mentioned this pull request Feb 22, 2020
Closed
10 tasks
@Mic92
Copy link
Member Author

Mic92 commented Feb 22, 2020

@GrahamcOfBorg test netdata

@Mic92 Mic92 merged commit ee08bd8 into NixOS:master Feb 24, 2020
@Mic92 Mic92 deleted the netdata branch February 24, 2020 17:24
@Frostman
Copy link
Member

LGTM. Package builds fine, tests/netdata passed, the new version seems to be working fine with my config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @Frostman