Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cozette: Init at 1.5.1 #80913

Merged
merged 2 commits into from Feb 24, 2020
Merged

Cozette: Init at 1.5.1 #80913

merged 2 commits into from Feb 24, 2020

Conversation

brettlyons
Copy link
Contributor

Motivation for this change

Package request: Cozette font #80267

Fixes #80267

cc @rnhmjoj @Soundtoxin

cole-h
cole-h requested changes Feb 23, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking into packaging this myself, but wanted to try building it from source. As you can probably tell, that didn't go according to plan, so thanks for picking this up!

pkgs/data/fonts/cozette/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/cozette/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/cozette/default.nix Outdated Show resolved Hide resolved
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Feb 23, 2020

I was looking into packaging this myself, but wanted to try building it from source. As you can probably tell, that didn't go according to plan, so thanks for picking this up!

I think it's fine not to build from source for a font. Given the package is simply copying files it could even be a fixed output derivation.

cole-h
cole-h requested changes Feb 24, 2020
View reviewed changes
pkgs/data/fonts/cozette/default.nix Show resolved Hide resolved
pkgs/data/fonts/cozette/default.nix Show resolved Hide resolved
pkgs/data/fonts/cozette/default.nix Show resolved Hide resolved
cole-h
cole-h reviewed Feb 24, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My final nitpick: most packages have their pname followed by version, and add a newline before src{,s}. Certainly not a blocking request, but it Just Looks Nicer™.

Thanks for bearing with my super nitpick-y requests!

pkgs/data/fonts/cozette/default.nix Outdated Show resolved Hide resolved
cole-h
cole-h approved these changes Feb 24, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks again for dealing with my various nitpicks :)

[5 built, 19 copied (13.0 MiB), 3.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80913
1 package built:
cozette

rnhmjoj
rnhmjoj requested changes Feb 24, 2020
View reviewed changes
pkgs/data/fonts/cozette/default.nix Outdated Show resolved Hide resolved
pkgs/data/fonts/cozette/default.nix Outdated Show resolved Hide resolved
rnhmjoj
rnhmjoj approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks all good now. Thank you.

@rnhmjoj rnhmjoj merged commit 9d0c560 into NixOS:master Feb 24, 2020
@brettlyons brettlyons deleted the cozette-font branch February 24, 2020 23:24
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 25, 2020
@rnhmjoj @dtzWill
Merge pull request NixOS#80913 from brettlyons/cozette-font
c108938 
Cozette: Init at 1.5.1
(cherry picked from commit 9d0c560)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: Cozette font
3 participants
@brettlyons @rnhmjoj @cole-h