Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metastore: init at 1.1.2 #80914

Merged
merged 1 commit into from Feb 28, 2020
Merged

metastore: init at 1.1.2 #80914

merged 1 commit into from Feb 28, 2020

Conversation

haskelious
Copy link
Contributor

Motivation for this change

Small Linux specific tool that is very useful to store metadata information of a folder structure (metadata such as file owners, groups, permissions) into a metadata "backup" file. Can then be used to restore/reapply the permissions later.

The typical use case is to store metadata of a folder structure in a git repository (along with the file changes) so a checkout of git can reapply the metadata intended by the original commit.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Feb 24, 2020
View reviewed changes
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/metastore/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/metastore/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/metastore/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/metastore/default.nix Outdated Show resolved Hide resolved
@haskelious
Copy link
Contributor Author

Ooops, something went terribly wrong with me trying to figure out how to update and rebase the commit ! I am not used to this yet. I will have to close this PR unless someone can help in getting it fixed.

@haskelious
Copy link
Contributor Author

@jonringer would you have any advice how to clean up my mistake with my attempt to rebase, which apparently brought lots of unrelated commits to this pull request? Alternatively I can close this one to start from a new branch and pull request.

@jonringer
Copy link
Contributor

assuming to just want the last 3 commits:

git rebase HEAD~3 --onto master
git push .. .. --force

jonringer
jonringer reviewed Feb 25, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

pkgs/os-specific/linux/metastore/default.nix Show resolved Hide resolved
pkgs/os-specific/linux/metastore/default.nix Outdated Show resolved Hide resolved
@haskelious
Copy link
Contributor Author

I believe I start to understand how to build these PR. Thank you for your support @jonringer.

@jonringer
Copy link
Contributor

each language framework/build tool chain is different.

@jonringer
Copy link
Contributor

@GrahamcOfBorg build metastore

jonringer
jonringer approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80914
1 package built:
metastore

@nlewo nlewo merged commit ec7bcb2 into NixOS:master Feb 28, 2020
@haskelious haskelious deleted the fix/metastore-create branch February 28, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@haskelious @jonringer @nlewo