Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.acoustics: disable #80825

Merged
merged 1 commit into from Feb 22, 2020
Merged

pythonPackages.acoustics: disable #80825

merged 1 commit into from Feb 22, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 22, 2020 •
edited

Motivation for this change

no longer compatible with pandas>=1

probably also applicable to ZHF

builder for '/nix/store/790sq5wi9fp7ci3pwdabdcnnprxbfqxg-python3.7-acoustics-0.2.3.drv' failed with exit code 1; last 10 log lines:
  E                       ValueError: Length of passed values is 1, index implies 4.

  /nix/store/nqxwx13rn7253jif95nh84ypv7arr6ks-python3.7-pandas-1.0.1/lib/python3.7/site-packages/pandas/core/series.py:292: ValueError
  =============================== warnings summary ===============================
  standards/test_iec_61672_1_2013.py:30
    /build/acoustics-0.2.3/tests/standards/test_iec_61672_1_2013.py:30: DeprecationWarning: invalid escape sequence \c
      """

  -- Docs: https://docs.pytest.org/en/latest/warnings.html
  ================== 1 failed, 503 passed, 1 warning in 16.30s ===================
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
pythonPackages.acoustics: disable
03bec6a 
no longer compatible with pandas>=1
@FRidh
Copy link
Member

FRidh commented Feb 22, 2020

yes still need to fix that python-acoustics/python-acoustics#242

@jonringer
Copy link
Contributor Author

I'm just fixing/disabling stuff that I see in reviews. This required upstream fixes, so i made a PR to disable. If you want to delay this until you get a fix, then I'm fine with that :)

@FRidh
Copy link
Member

FRidh commented Feb 22, 2020

No just go ahead, I don't know when I get to fixing that. It's not very high on my list.

@jonringer jonringer merged commit 2fea715 into NixOS:master Feb 22, 2020
@jonringer jonringer deleted the disable-acoustics branch February 23, 2020 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh