Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

traefik: 1.7.14 -> 1.7.21 #80824

Closed
wants to merge 1 commit into from
Closed

traefik: 1.7.14 -> 1.7.21 #80824

wants to merge 1 commit into from

Conversation

ngerstle
Copy link
Contributor

Motivation for this change

I noticed that traefik was several versions out of date. With full respect to #76723 and the 1.7 vs 2.0 discussion, this bumps the older, but still maintained, 1.7 version of traefik.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ngerstle
Copy link
Contributor Author

@ehmry I don't have access to merge, so you or or another maintainer will need to do so.

@rnhmjoj rnhmjoj changed the base branch from master to release-20.03 March 2, 2020 15:53
@rnhmjoj rnhmjoj changed the base branch from release-20.03 to master March 2, 2020 15:53
rnhmjoj
rnhmjoj approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and run with nix-review. Being a bugfix release it makes sense to target 20.03 and 19.09.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Mar 2, 2020

Changing the branch from github creates a mess, I'll manually merge this.

@ofborg ofborg bot requested a review from ehmry March 2, 2020 15:59
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Mar 2, 2020

release-20.03: 3c45fc8
release-19.09: 52c1125

@rnhmjoj rnhmjoj closed this Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@jokogr jokogr Awaiting requested review from jokogr

@kalbasit kalbasit Awaiting requested review from kalbasit

@moredhel moredhel Awaiting requested review from moredhel

@vdemeester vdemeester Awaiting requested review from vdemeester

@ehmry ehmry Awaiting requested review from ehmry

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ngerstle @rnhmjoj @ehmry