Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

poetry: 0.12.17 -> 1.0.3 (20.03 Backport) #80826

Merged
merged 1 commit into from Feb 23, 2020
Merged

poetry: 0.12.17 -> 1.0.3 (20.03 Backport) #80826

merged 1 commit into from Feb 23, 2020

Conversation

deingithub
Copy link
Contributor

Cherry picked from commit 011e2d3/#80819

And a ping to @worldofpeace and @disassembler each, manually because I don't seem to be able to actually ping the group.

Motivation for this change

Needs backporting for #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@deingithub
poetry: 0.12.17 -> 1.0.3
6749c48 
(cherry picked from commit 011e2d3)
@ofborg ofborg bot requested a review from jbaum98 February 22, 2020 20:29
@worldofpeace
Copy link
Contributor

@deingithub Teams are only mention-able from members of the organization.
The actual ZHF mentioned the committers team and the maintainers team, which exists for a special purpose. More details https://discourse.nixos.org/t/join-the-package-maintainer-team/3751

@worldofpeace
Copy link
Contributor

At a glance this is a major version bump, can you link some sort of release notes?

@deingithub
Copy link
Contributor Author

deingithub commented Feb 22, 2020 •
edited

Indeed it is a major release (though immediately following 0.12.x), with all added/changed features here: https://python-poetry.org/history#1-0-0-2019-12-12. The patch versions since then have only added bugfixes and no new features.

@jonringer
Copy link
Contributor

You can see from the nix-review on the other pr that this package is no longer referenced for building pyproject python packages, so this package will only be important if someone "imports" poetry

@FRidh FRidh merged commit 81e45e8 into NixOS:release-20.03 Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@jbaum98 jbaum98 Awaiting requested review from jbaum98

@adisbladis adisbladis Awaiting requested review from adisbladis

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deingithub @worldofpeace @jonringer @FRidh