Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lbzip2 build #80906

Merged
merged 4 commits into from Feb 27, 2020
Merged

Fix lbzip2 build #80906

merged 4 commits into from Feb 27, 2020

Conversation

bennofs
Copy link
Contributor

@bennofs bennofs commented Feb 23, 2020

Motivation for this change

Fix build of lbzip2. Depends on #80905.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ZHF: #80379 @NixOS/nixos-release-managers

@bennofs
gnulib: 20190811 -> 20200223
9d5cc98 
This update makes gnulib work even if it is installed into a readonly
location, so some hacks in nixpkgs can be removed.
@bennofs
xprintidle-ng: simplify gnulib usage
4ca87c0
@bennofs
grub2: simplify gnulib usage
98bb71f
@bennofs
lbzip2: fix build
07cf036 
The release tarball is no longer available at the specified URL, so
building from git. Also, the gnulib in the release tarball was too old
for our recent glibc version.
@ofborg ofborg bot requested review from 7c6f434c and abbradar February 23, 2020 18:33
@mmilata
Copy link
Member

mmilata commented Feb 24, 2020 •
edited

also did this in #80560
though the updated gnulib sure is nicer than --symlinks --more-symlinks

@7c6f434c 7c6f434c merged commit c500805 into NixOS:master Feb 27, 2020
@onny
Copy link
Contributor

onny commented Aug 16, 2020

Could this be backported to 20.03 branch? I really would like to use it for a package!

bennofs added a commit that referenced this pull request Aug 19, 2020
@bennofs
lbzip2: fix build
fc96673 
This is backport of #80560 (since we don't have updated gnulib in 20.03)
and #80906.

Based on 07cf036
@bennofs
Copy link
Contributor Author

bennofs commented Aug 19, 2020

@onny done: fc96673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bennofs @mmilata @onny @7c6f434c