Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnulib: 20190811 -> 20200223 and simplify usage #80905

Merged
merged 3 commits into from Feb 27, 2020
Merged

gnulib: 20190811 -> 20200223 and simplify usage #80905

merged 3 commits into from Feb 27, 2020

Conversation

bennofs
Copy link
Contributor

@bennofs bennofs commented Feb 23, 2020 •
edited

Motivation for this change

Update gnulib, which allows it to work correctly if installed to readonly location. We don't need to copy the gnulib sources in each build anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bennofs
gnulib: 20190811 -> 20200223
9d5cc98 
This update makes gnulib work even if it is installed into a readonly
location, so some hacks in nixpkgs can be removed.
@bennofs
xprintidle-ng: simplify gnulib usage
4ca87c0
@bennofs
grub2: simplify gnulib usage
98bb71f
@bennofs bennofs changed the title ###### Motivation for this change gnulib: 20190811 -> 20200223 and simplify usage Feb 23, 2020
@bennofs bennofs mentioned this pull request Feb 23, 2020
Merged
10 tasks
@ofborg ofborg bot requested a review from 7c6f434c February 23, 2020 18:32
@Ma27 Ma27 self-requested a review February 24, 2020 03:14
@mmilata
Copy link
Member

mmilata commented Feb 24, 2020

fyi #80840

@7c6f434c 7c6f434c merged commit 93f5b02 into NixOS:master Feb 27, 2020
@nlewo nlewo mentioned this pull request Feb 28, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

@7c6f434c 7c6f434c 7c6f434c approved these changes

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bennofs @mmilata @7c6f434c @Ma27