Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry: Fix build with Python 3.8 #80880

Merged
merged 1 commit into from Feb 23, 2020
Merged

Conversation

infinisil
Copy link
Member

Motivation for this change

Poetry build with python 3.8 was broken:

$ nix-build -E 'with import ./. {}; poetry.override { python = python38; }'
error: value is null while a set was expected, at /nix/store/24kjp6k6piq42jxvzx80imdx0ysz6grz-nixexprs.tar.xz
  /pkgs/development/tools/poetry2nix/poetry2nix/overrides.nix:569:27 (use '--show-trace' to show detailed location information)

See nix-community/poetry2nix#50 for further info. The proper fix might take a while to be implemented. This here is only a workaround until then.

Ping @adisbladis

This PR is sponsored by Niteo

Things done
  • Checked that the normal Python 3.7 poetry still builds: nix-build -A poetry
  • Checked that now a Python 3.8 poetry builds with nix-build -E 'with import ./. {}; poetry.override { python = python38; }'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants