Python packages.fluidasserts #80828
Python packages.fluidasserts #80828
Conversation
- Keberos is a dependency that you really want included in the pkg, this is also needed to run the test suite by default
- Release entirely the version pinning, the active development of the package makes it be compatible with the latest dependency versions - Added more tests, and missing packages
There was a problem hiding this comment.
diff LGTM
commits LGTM
failure is an upstream issue
[12 built (1 failed), 27 copied (158.2 MiB), 3.3 MiB DL]
error: build of '/nix/store/sfglznhrmqaryvp7i50sxwdg5marn9sa-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80828
1 package failed to build:
python38Packages.pywinrm
8 package built:
fluidasserts python27Packages.pywinrm python37Packages.graphql-core python37Packages.graphql-server-core python37Packages.promise python37Packages.pywinrm python38Packages.graphql-core python38Packages.promise
failure:
/nix/store/9nh4qk8zjgzqlnzj6hp5n1nkyzicss4x-python3.8-unittest2-1.1.0/lib/python3.8/site-packages/unittest2/compatibility.py:143: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated since Python 3.3, and in 3.9 it will stop working
class ChainMap(collections.MutableMapping):
|
@jonringer in the last force push I disabled pywinrm for py38 so now the nix-review passes |
There was a problem hiding this comment.
LGTM
[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80828
8 package built:
fluidasserts python27Packages.pywinrm python37Packages.graphql-core python37Packages.graphql-server-core python37Packages.promise python37Packages.pywinrm python38Packages.graphql-core python38Packages.promise
|
@GrahamcOfBorg build fluidasserts python27Packages.pywinrm python37Packages.graphql-core python37Packages.graphql-server-core python37Packages.promise python37Packages.pywinrm python38Packages.graphql-core python38Packages.promise |
|
@kamadorueda do you care about fluidasserts being available on the release channel? It's still broken on |
|
@jonringer where do you see that info? last time I reviewed some hydra logs and adjusted the package to pass |
|
@jonringer alright! although it seems to be the previous hard-pinned-dependencies problem https://hydra.nixos.org/build/113405614/nixlog/1 i'll keep an eye on it |
|
it does, but if your use case only includes unstable, then I'm not sure how much benefit you will get |
|
@kamadorueda In this PR, you introduced graphql-core and graphql-server-core. These packages depend on the rx package. I am upgrading the rx package as a part of my PR (#71166). graphql-core has a release (3.1.0) which is compatible with rx version 3, but graphql-server-core does not yet have a release which is compatible. With my unmerged PR, the graphql-core (and thus the graphql-server-core) builds are broken. I don't see any use of graphql-server-core or graphql-core in this PR. fluidasserts doesn't seem to depend on these packages. I see a few options:
Let me know what you recommend. I am leaning toward option 2. |
|
fluidasserts has been broken for over a month, I would say just do upgrade of rx to 3.0, and mark |
I want to upgrade rx (a Python library) from version 1.6 to version 3.0. graphql-core version 2.3.1 requires rx version <2. This prevents me from upgrading rx. Upgrade graphql-core to the latest release, removing its dependency on rx entirely. Unfortunately, graphql-server-core (which depends on graphql-core) does not have a release which works with this latest version of graphql-core. Because graphql-server-core isn't used anywhere yet [1], disable the package to unblock me upgrading rx. [1] NixOS#80828 (comment)
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)