Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

powershell: update supported platforms #80830

Merged
merged 1 commit into from Feb 23, 2020
Merged

powershell: update supported platforms #80830

merged 1 commit into from Feb 23, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 22, 2020 •
edited

Motivation for this change

update platforms to reflect actual supported builds

related: #80523

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from yrashk February 22, 2020 21:16
@jonringer jonringer merged commit 7e1b217 into NixOS:master Feb 23, 2020
@jonringer jonringer deleted the update-powershell-platforms branch February 26, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrashk yrashk Awaiting requested review from yrashk

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @yrashk