Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.pybullet: 2.6.1 -> 2.6.6 #80859

Merged
merged 1 commit into from Feb 23, 2020
Merged

Conversation

mjlbach
Copy link
Contributor

@mjlbach mjlbach commented Feb 23, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mjlbach
Copy link
Contributor Author

mjlbach commented Feb 23, 2020

Should fix failing build for #80379, so probably should backport

@mjlbach mjlbach changed the title pybullet: 2.6.1 -> 2.6.6 python.pkgs.pybullet: 2.6.1 -> 2.6.6 Feb 23, 2020
@mjlbach mjlbach force-pushed the pybullet-2.6.6 branch 2 times, most recently from fb963ec to d9dfa03 Compare February 23, 2020 15:58
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add numpy to propagatedBuildInputs

  ERROR: Could not find a version that satisfies the requirement numpy (from pybullet==2.6.6) (from versions: none)
  ERROR: No matching distribution found for numpy (from pybullet==2.6.6)
builder for '/nix/store/f3ay0r5hjr8s1xhx6caw690d1p649f8c-python3.8-pybullet-2.6.6.drv' failed with exit code 1; last 10 log lines:
  adding 'pybullet-2.6.6.dist-info/top_level.txt'
  adding 'pybullet-2.6.6.dist-info/RECORD'
  removing build/bdist.linux-x86_64/wheel
  Finished executing setuptoolsBuildPhase
  installing
  Executing pipInstallPhase
  /build/pybullet-2.6.6/dist /build/pybullet-2.6.6
  Processing ./pybullet-2.6.6-cp38-cp38-linux_x86_64.whl
  ERROR: Could not find a version that satisfies the requirement numpy (from pybullet==2.6.6) (from versions: none)
  ERROR: No matching distribution found for numpy (from pybullet==2.6.6)
builder for '/nix/store/b4r7izgjg10vb96xln00jxk5zkfjcf0v-python3.7-pybullet-2.6.6.drv' failed with exit code 1; last 10 log lines:
  adding 'pybullet-2.6.6.dist-info/top_level.txt'
  adding 'pybullet-2.6.6.dist-info/RECORD'
  removing build/bdist.linux-x86_64/wheel
  Finished executing setuptoolsBuildPhase
  installing
  Executing pipInstallPhase
  /build/pybullet-2.6.6/dist /build/pybullet-2.6.6
  Processing ./pybullet-2.6.6-cp37-cp37m-linux_x86_64.whl
  ERROR: Could not find a version that satisfies the requirement numpy (from pybullet==2.6.6) (from versions: none)
  ERROR: No matching distribution found for numpy (from pybullet==2.6.6)
cannot build derivation '/nix/store/crgaqv6ahgqv33j08p3231anxg3f81f9-env.drv': 3 dependencies couldn't be built
[1 built (3 failed), 0.0 MiB DL]
error: build of '/nix/store/crgaqv6ahgqv33j08p3231anxg3f81f9-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80859
3 package failed to build:
python27Packages.pybullet python37Packages.pybullet python38Packages.pybullet

@mjlbach
Copy link
Contributor Author

mjlbach commented Feb 23, 2020

Done

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash commits

git reset HEAD^^
git add pkgs/
git commit --amend --no-edit
git push .. .. --force

@mjlbach mjlbach force-pushed the pybullet-2.6.6 branch 3 times, most recently from c7ba54d to 041e823 Compare February 23, 2020 22:13
Update static-libs.patch

Add numpy to pybullet propagatedBuildInputs

Added numpy to build inputs
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/80859
3 package built:
python27Packages.pybullet python37Packages.pybullet python38Packages.pybullet

@jonringer jonringer merged commit 74f312e into NixOS:master Feb 23, 2020
@timokau
Copy link
Member

timokau commented Feb 23, 2020

Thanks for taking care of this!

@mjlbach mjlbach deleted the pybullet-2.6.6 branch February 26, 2020 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants