Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chefdk: 2.4.17 -> 4.7.73 #80858

Merged
merged 2 commits into from Feb 29, 2020
Merged

chefdk: 2.4.17 -> 4.7.73 #80858

merged 2 commits into from Feb 29, 2020

Conversation

jerith666
Copy link
Contributor

Motivation for this change

fixes breakage due to dependency on older version of ruby

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from offlinehacker February 23, 2020 02:52
nlewo
nlewo requested changes Feb 28, 2020
View reviewed changes
Copy link
Member

@nlewo nlewo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerith666 Could you fix the aarch64 build or disable this platform (since this build is failing)?

@jerith666 jerith666 requested a review from nlewo February 29, 2020 03:36
@jerith666
Copy link
Contributor Author

I don't have an aarch64 machine to test on, so I've just marked it broken.

@nlewo
Copy link
Member

nlewo commented Feb 29, 2020

@GrahamcOfBorg build chefdk

@nlewo
Copy link
Member

nlewo commented Feb 29, 2020

Thx @jerith666

@nlewo nlewo merged commit a83ffc0 into NixOS:master Feb 29, 2020
This was referenced Feb 29, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jerith666 @nlewo