Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin: fix NIX_LDFLAGS usages #80890

Merged
merged 2 commits into from Apr 3, 2020
Merged

darwin: fix NIX_LDFLAGS usages #80890

merged 2 commits into from Apr 3, 2020

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Feb 23, 2020

Motivation for this change

Backport of #80603 and #80635.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 23, 2020
@ofborg ofborg bot requested a review from mboes February 23, 2020 12:25
@worldofpeace worldofpeace added the 8.has: port to stable A PR already has a backport to the stable release. label Feb 23, 2020
@LnL7 LnL7 mentioned this pull request Mar 28, 2020
Merged
10 tasks
eraserhd and others added 2 commits April 3, 2020 22:27
@eraserhd @LnL7
plan9port: fix linker flags for macosx
6693266 
(cherry picked from commit 4d2a825)
(cherry picked from commit 7724ef7)
@marsam @LnL7
bazel: fix linker flags for darwin
f941714 
(cherry picked from commit d1ee615)
@LnL7 LnL7 merged commit 1c32029 into NixOS:release-20.03 Apr 3, 2020
@LnL7 LnL7 deleted the darwin-ldflags branch April 3, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@mboes mboes Awaiting requested review from mboes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LnL7 @worldofpeace @eraserhd @marsam