Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ostree: 2019.6 -> 2020.2 #80837

Merged
merged 2 commits into from Feb 24, 2020
Merged

ostree: 2019.6 -> 2020.2 #80837

merged 2 commits into from Feb 24, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Feb 22, 2020

https://github.com/ostreedev/ostree/releases/tag/v2020.1
https://github.com/ostreedev/ostree/releases/tag/v2020.2

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from copumpkin February 22, 2020 22:35
@jtojnar
Copy link
Contributor

jtojnar commented Feb 24, 2020 •
edited

@GrahamcOfBorg test installed-tests.ostree

@jtojnar
Copy link
Contributor

jtojnar commented Feb 24, 2020

Still not sure why are the NixOS tests timing out (and not being killed by the gnome-desktop-testing-runner) but they pass when ran in user profile:

env TEST_SKIP_CLEANUP=1 OT_TESTS_DEBUG=1 nix --option experimental-features nix-command  run -f . gnome-desktop-testing ostree -c gnome-desktop-testing-runner -d $(nix-build -A ostree.installedTests --no-out-link)/share -t 1800

@jtojnar jtojnar merged commit 7fb671e into NixOS:master Feb 24, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Feb 24, 2020

Thanks.

@zowoq zowoq deleted the ostree-2020-2 branch February 24, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@copumpkin copumpkin Awaiting requested review from copumpkin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zowoq @jtojnar