pythonPackages.pyfribidi: fix build #80838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build pythonPackages.pyfribidi python38Packages.pyfribidi python37Packages.pyfribidi python36Packages.pyfribidi python35Packages.pyfribidi |
|
@GrahamcOfBorg build pythonPackages.pyfribidi |
jonringer
approved these changes
Feb 22, 2020
There was a problem hiding this comment.
LGTM for x64-linux
[4 built, 1 copied (0.7 MiB), 0.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80838
3 package built:
python27Packages.pyfribidi python37Packages.pyfribidi python38Packages.pyfribidi
might be nice to address darwin issues (or disable, looks like upstream issues)
jonringer
reviewed
Feb 22, 2020
| }: | ||
|
|
||
| buildPythonPackage rec { | ||
| version = "0.12.0"; | ||
| pname = "pyfribidi"; | ||
| disabled = isPy3k || isPyPy; | ||
| disabled = isPyPy; |
There was a problem hiding this comment.
Suggested change
| disabled = isPyPy; | |
| disabled = isPyPy || stdenv.cc.isClang; |
quick and easy way to disable failing clang builds
There was a problem hiding this comment.
Thank you! In this case build log looks like there is a single, easy to fix error. Maybe small patch will be enough.
| @@ -0,0 +1,17 @@ | |||
| diff --git a/pyfribidi.c b/pyfribidi.c | |||
| index 9a0120d..238134a 100644 | |||
| --- a/pyfribidi.c | |||
There was a problem hiding this comment.
Nice, could you please try to upstream this?
This was referenced Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing dependency: six.
Pyfribidi 0.12.0 supports Python 3.
Motivation for this change
ZHF: #80379
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)