Codechange: Limit field width to avoid sscanf crash #8017
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Cppcheck, "sscanf() without field width limits can crash with huge input data."
I added a field width of 127 since
cp->text
is a buffer of size32 * MAX_CHAR_LENGTH
(src/command_type.h:483) where MAX_CHAR_LENGTH = 4 (src/strings_type.h:18), so a total length of 128. Cppcheck recommends to subtract one from the field width to leave room for the null byte at the end of the buffer.Cppcheck error below: