Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Crash]: In Squirrel destructor #9548

Closed
SamuXarick opened this issue Sep 11, 2021 · 2 comments
Closed

[Crash]: In Squirrel destructor #9548

SamuXarick opened this issue Sep 11, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@SamuXarick
Copy link
Contributor

Version of OpenTTD

12.0-beta2, Windows 10

Steps to reproduce

I was watching multiple AIs playing, and it just crashed out of nowhere.

Upload crash files

OpenTTD.zip
@glx22
Copy link
Contributor

glx22 commented Sep 11, 2021 

>	openttd.exe!sqvector<SQObjectPtr>::resize(unsigned __int64 newsize, const SQObjectPtr & fill) Ligne 62	C++
 	openttd.exe!SQArray::Finalize() Ligne 23	C++
 	openttd.exe!SQSharedState::~SQSharedState() Ligne 197	C++
 	openttd.exe!sq_close(SQVM * v) Ligne 132	C++
 	openttd.exe!Squirrel::Uninitialize() Ligne 759	C++
 	openttd.exe!Squirrel::~Squirrel() Ligne 751	C++
 	openttd.exe!ScriptInstance::Died() Ligne 163	C++
 	openttd.exe!AIInstance::Died() Ligne 63	C++
 	openttd.exe!`ScriptInstance::GameLoop'::`1'::catch$5() Ligne 253	C++
 	[Code externe]	
 	openttd.exe!ScriptInstance::GameLoop() Ligne 245	C++
 	openttd.exe!AI::GameLoop() Ligne 82	C++
 	openttd.exe!StateGameLoop() Ligne 1380	C++
 	openttd.exe!GameLoop() Ligne 1469	C++
 	openttd.exe!VideoDriver::GameLoop() Ligne 37	C++
 	openttd.exe!VideoDriver::GameThread() Ligne 46	C++
 	openttd.exe!StartNewThread::__l3::<lambda>(const char * name, void(*)(VideoDriver *) && F, VideoDriver * && <A_0>) Ligne 65	C++
 	[Code externe]	
 	openttd.exe!thread_start<unsigned int (__cdecl*)(void *),1>(void * const parameter) Ligne 97	C++
 	[Code externe]

@LordAro LordAro changed the title [Crash]: [Crash]: In Squirrel destructor Sep 11, 2021
@SamuXarick
Copy link
Contributor Author

Steps to reproduce:

  • Set a maximum memory limit to 8 MiB to speed up testing
  • Start AIs that surpass that limit
  • Hope for a crash to happen as it may not always crash

The crash files uploaded in the original post indicate it was trAIns that caused OpenTTD to crash, but I found out it may crash with other AIs as well.

@TrueBrain TrueBrain added the bug Something isn't working label Sep 14, 2021
glx22 added a commit to glx22/OpenTTD that referenced this issue Oct 2, 2021
@glx22
Fix OpenTTD#9548, e5fedcd: [Squirrel] Crash during engine cleanup aft…
1543fe4 
…er reaching memory limit on realloc
@glx22 glx22 closed this as completed in a53cfee Oct 2, 2021
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this issue Oct 3, 2021
@glx22 @TrueBrain
Fix OpenTTD#9548, e5fedcd: [Squirrel] Crash during engine cleanup aft…
0663e45 
…er reaching memory limit on realloc (OpenTTD#9592)
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this issue Oct 3, 2021
@glx22 @TrueBrain
Fix OpenTTD#9548, e5fedcd: [Squirrel] Crash during engine cleanup aft…
32957d7 
…er reaching memory limit on realloc (OpenTTD#9592)
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this issue Oct 3, 2021
@glx22 @TrueBrain
Fix OpenTTD#9548, e5fedcd: [Squirrel] Crash during engine cleanup aft…
c57d4e7 
…er reaching memory limit on realloc (OpenTTD#9592)
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this issue Oct 3, 2021
@glx22 @TrueBrain
Fix OpenTTD#9548, e5fedcd: [Squirrel] Crash during engine cleanup aft…
9391052 
…er reaching memory limit on realloc (OpenTTD#9592)
TrueBrain pushed a commit to TrueBrain/OpenTTD that referenced this issue Oct 3, 2021
@glx22 @TrueBrain
Fix OpenTTD#9548, e5fedcd: [Squirrel] Crash during engine cleanup aft…
85eabf9 
…er reaching memory limit on realloc (OpenTTD#9592)
TrueBrain pushed a commit that referenced this issue Oct 3, 2021
@glx22 @TrueBrain
Fix #9548, e5fedcd: [Squirrel] Crash during engine cleanup after reac…
5d5ff3e 
…hing memory limit on realloc (#9592)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TrueBrain @glx22 @SamuXarick