New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #9523: Display icon or text in vehicle list or in vehicle window indicating whether a vehicle is lost #9543
Feature #9523: Display icon or text in vehicle list or in vehicle window indicating whether a vehicle is lost #9543
Conversation
2b109e9
to
12a066a
Compare
Reusing a sprite is totally fine here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, other than a couple of minor points
…cle window indicating whether a vehicle is lost
12a066a
to
5616fba
Compare
Are you happy with the result? Can we un-draft this? :D |
It's a bit messed up. It doesn't immediately pick up the status when the route is fixed. And in some cases, it can reach the target while still saying that it cannot be reached. I did a few testings with trains and a missing single track that gets fixed meanwhile, and it took the train some time to clear up the train is lost status. |
Is this because the GUI doesn't update? Or because the PF just caches information and takes a bit of time to notice the track is restored? The first we can fix. The second .. I personally can accept that as a "known-bug". We cannot instantly update all trains if you put down a single rail :) I think the benefit of this PR out wages the possible questions that might give. |
The second. |
beep beep IRC to GitHub bot here:
In other words, yes, this PR would "introduce a bug", but not one we might want to solve in this PR :) |
Motivation / Problem
#9523
Description
While VF_PATHFINDER_LOST is set for a vehicle, a warning icon is displayed on vehicle window and vehicle list. On the vehicle window, status bar text will change from "heading to" to "can't reach".
Limitations
I am reusing a sprite! Pretty sure this is not the way to go.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.