Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Multiplayer #9539

Closed
wants to merge 2 commits into from
Closed

Doc: Multiplayer #9539

wants to merge 2 commits into from

Conversation

Berbe
Copy link
Contributor

@Berbe Berbe commented Sep 4, 2021

Motivation / Problem

Name resolution problems in Docker containers environment are poorly documented, and no solution is provided.

Description

Aims at:

  • Refactor section 6.0 formatting
  • Provides details on the Docker container problem and associated solution

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

LordAro
LordAro reviewed Sep 7, 2021
View reviewed changes
Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also might as well remove the "Last updated" line from the top of the file

docs/multiplayer.md
Comment on lines +229 to +230
The solution is then to force custom name servers for said containers to be a
list of IPv4 ones.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saying "do this thing" without actually saying how to do it (and a cursory google doesn't reveal anything obvious), isn't particularly useful. Can you expand on this?

@TrueBrain TrueBrain added this to the 12.0 milestone Sep 12, 2021
@TrueBrain TrueBrain mentioned this pull request Sep 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Berbe @LordAro @TrueBrain