Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Add configurable docking tile occupied penalty for NPF and YAPF #9553

Closed
wants to merge 1 commit into from
Closed

Change: Add configurable docking tile occupied penalty for NPF and YAPF #9553

wants to merge 1 commit into from

Conversation

SamuXarick
Copy link
Contributor

Motivation / Problem

Personally, I'd like to be able to configure docking tile occupied penalty to 0, so that there is a way to make the pathfinder behave more like it used to before this penalty was introduced. ship_curve45_penalty and ship_curve90_penalty were introduced recently and are configurable, so why not the docking tile?

Description

Add configurable docking tile occupied penalty for NPF and YAPF

Limitations

Checklist for review

Some things are not automated, and forgotten often. This list is a reminder for the reviewers.

  • The bug fix is important enough to be backported? (label: 'backport requested')
  • This PR touches english.txt or translations? Check the guidelines
  • This PR affects the save game format? (label 'savegame upgrade')
  • This PR affects the GS/AI API? (label 'needs review: Script API')
    • ai_changelog.hpp, gs_changelog.hpp need updating.
    • The compatibility wrappers (compat_*.nut) need updating.
  • This PR affects the NewGRF API? (label 'needs review: NewGRF')

@SamuXarick SamuXarick force-pushed the configurable-docking-tile-penalty branch from 53ba0f9 to a27d3de Compare September 13, 2021 19:23
@TrueBrain
Copy link
Member

Yeah, I think even you understand why I close this PR :P

But to put it in words:

  • Your motivation is basically: because I personally like it. Good for you, use this PR locally :) That is hardly a reason to accept the PR of course :)
  • ship_curve45_penalty and ship_curve90_penalty were introduced recently .. don't know how your clock works, but this was introduced 18 (!) months ago. Please don't deceive people ;)
  • As you are well aware, we are not adding more settings without good reasons :) If you can present a good reason, please do. But I hope we all agree this is not that :)

@TrueBrain TrueBrain closed this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SamuXarick @TrueBrain