Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-edit some sounds to relicense them #13

Merged
merged 1 commit into from Feb 9, 2021

Conversation

Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented Feb 4, 2021

There are still many Sampling Plus 1.0'ed sounds in the repository. These remaining sounds are mostly based on libre sources, but the editor slapped a non-free license on them.
To be able to get rid of the non-free Sampling Plus license, I took the original libre sound, edited it myself, and applied a libre license on it. (CC0, CC BY 3.0 or CC BY-SA 3.0, always the same as the source sound's license).
Most sounds should sound mostly the same as before, but they are technically not the same.

The two sounds 46 and 49 (toyland bubble generator) are completely new, since no source files could be found for those. I think my sounds are a bit better anyway, as they are a bit more cartoonish. :-) (please hear and test for yourself).

After this PR, almost all sounds will be libre with the exception of only sound which is still be Sampling Plus'ed: osfx_23.wav "Plane wheels touching ground". Unfortunately, the editor is not listed here, so I assume the worst. Anyway, I find it very hard to redo this one, and I did not yet succeed in finding a possible replacement sound that sounds like a brake either.
If you want to give it a shot, here's the source sound: https://freesound.org/people/audible-edge/sounds/71740/

This PR is still mergable, the final sound could be dealt with later.

These sounds were based on libre sources, but the sound editors
released them under a non-libre license.
I re-edited the sounds based on the libre sources, so I was able to
change the license to a libre one.
Sounds 23, 46 and 49 are completely new, since no source files could be found.
@Wuzzy2
Copy link
Contributor Author

Wuzzy2 commented Feb 4, 2021

UPDATE! I have now created a replacement for osfx_23.wav as well, based on a CC0 sound from Freesound.org. So please check out this sound as well.

Now with this PR, ALL sounds will be under a libre CC license (either CC0, CC BY 3.0, or CC BY-SA 3.0). :-)

After this PR, the README still needs updating, and other minor cleanup work needs to be done. Stay tuned!

Copy link
Contributor

@planetmaker planetmaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable. Thank you :)

Copy link
Contributor

@orudge orudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, the new sounds are good. :)

@orudge orudge merged commit 891a6d1 into OpenTTD:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants