Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 056d41949e5b
Choose a base ref
...
head repository: NixOS/nix
compare: 45dda96dd625
Choose a head ref
  • 17 commits
  • 17 files changed
  • 5 contributors

Commits on Feb 1, 2021

  1. --no-net -> --offline

    domenkozar committed Feb 1, 2021
    Copy the full SHA
    d0b74e2 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #4500 from domenkozar/offline

    --no-net -> --offline
    edolstra committed Feb 1, 2021
    Copy the full SHA
    d0a04d1 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    fb00e7d View commit details
    Browse the repository at this point in the history
  4. Merge pull request #4501 from dschrempf/master

    Remove newline in operator table.
    edolstra committed Feb 1, 2021
    Copy the full SHA
    0e05cb6 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. Copy the full SHA
    76d8bdf View commit details
    Browse the repository at this point in the history
  2. Merge pull request #4514 from sternenseemann/tryeval-doc

    Include note about type of catched errors in tryEval documentation
    edolstra committed Feb 3, 2021
    Copy the full SHA
    c8937ba View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2021

  1. Copy the full SHA
    9146c9d View commit details
    Browse the repository at this point in the history
  2. Add an evaluation caching mechanism

    Add the caching mechanism already present for cli arguments to the
    evaluation loop.
    
    This means that an expression of the form `(builtins.getFlake
    foo).bar.baz` will be cached if it can be
    thufschmitt committed Feb 4, 2021
    Copy the full SHA
    49dacb2 View commit details
    Browse the repository at this point in the history
  3. Manually commit to the cache db during the eval

    This is a dirty hack to make caching temporarily work.
    
    The issue seems to be that the cache object is never deleted, which in
    turn means that we never commit to the db (as it happens in the object's
    destructor), so the cache doesn't persist between two Nix calls.
    So we manually commit to the db each time. This is both slower and ugly,
    but at least it works for the moment
    thufschmitt committed Feb 4, 2021
    Copy the full SHA
    480a523 View commit details
    Browse the repository at this point in the history
  4. Only add an eval cache to the attribute sets

    The others don't need it and it was taking some useless space in the
    `Value` type
    thufschmitt committed Feb 4, 2021
    Copy the full SHA
    57b34c5 View commit details
    Browse the repository at this point in the history
  5. make the eval cache reentrant

    Avoids sqlite lock issue when the same flake is evaluated twice by
    keeping an in-memory mapping of the db connections opened for each cache
    key
    thufschmitt committed Feb 4, 2021
    Copy the full SHA
    e739f46 View commit details
    Browse the repository at this point in the history
  6. Copy the full SHA
    7202659 View commit details
    Browse the repository at this point in the history
  7. Fix a clang warning

    Re-order the initialisers in a constructor to make them match the
    actual initialisation order
    thufschmitt committed Feb 4, 2021
    Copy the full SHA
    77f9a29 View commit details
    Browse the repository at this point in the history
  8. Copy the full SHA
    72d26f8 View commit details
    Browse the repository at this point in the history
  9. Copy the full SHA
    77ea6eb View commit details
    Browse the repository at this point in the history
  10. Copy the full SHA
    a2aee4d View commit details
    Browse the repository at this point in the history
  11. Copy the full SHA
    45dda96 View commit details
    Browse the repository at this point in the history