Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't treat transforms with rotation or skew as having invalid scale #27688

Merged
merged 1 commit into from Feb 23, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Feb 18, 2021

We can calculate quite accurate scale for any transform without
perspective using gfx::ComputeTransform2dScaleComponents(), so we
can stop treating rotation and skew as having invalid scale, to make
raster scale for animations containing such transform operations
more accurate.

Bug: 1178439
Change-Id: I2a54bfd0c0da5e1107fa638966e1fe9f637582f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698487
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856867}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot changed the title Don't treat rotation etc. having invalid scale Don't treat transforms with rotation or skew as having invalid scale Feb 23, 2021
We can calculate quite accurate scale for any transform without
perspective using gfx::ComputeTransform2dScaleComponents(), so we
can stop treating rotation and skew as having invalid scale, to make
raster scale for animations containing such transform operations
more accurate.

Bug: 1178439
Change-Id: I2a54bfd0c0da5e1107fa638966e1fe9f637582f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2698487
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856867}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants