Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify requirements.txt to accomodate changes in fasm #124

Open
Mattia9875 opened this issue Feb 19, 2021 · 4 comments
Open

Modify requirements.txt to accomodate changes in fasm #124

Mattia9875 opened this issue Feb 19, 2021 · 4 comments

Comments

@Mattia9875
Copy link

Mattia9875 commented Feb 19, 2021 •
edited

In xc7/requirements.txt
substitute git+https://github.com/symbiflow/fasm
with --no-use-pep517 git+https://github.com/SymbiFlow/fasm.git#egg=fasm

as of issue over on /symbiflow/fasm

mentioning this because the issue causes conda to fail the env creation process, rendering the image in a docker enviroment unbuildable
@litghost
Copy link
Contributor

Now that fasm is on PyPi, the xc7/requirements can just remove the fasm requirement completely now that it is in PyPi.

@Mattia9875
Copy link
Author

You mean that in the sense that i could do it on my system? or that is the general way to fix it?

@litghost
Copy link
Contributor

You mean that in the sense that i could do it on my system? or that is the general way to fix it?

As in you/I could submit a PR to fix this?

@Mattia9875
Copy link
Author

Yes, though Tim responded on the issue I cited saying that he is currently working on in so I don't know how this issue will stand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@litghost @Mattia9875