Fix d437445c: also use std::chrono for the GRFFileScanner modal window #8699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason I only converted one of the two modal windows we have, and completely forgot the other. While at it, synchronize the way those two modal windows work in terms of "next_update".
TrueBrain
force-pushed
the
fix-60fps-again
branch
from
9715fdb
to
12bb603
Compare
glx22
approved these changes
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8697
Motivation / Problem
In some weird moment of insanity, I converted one of the two modal windows to use
std::chrono, but forgot to convert the other. No clue where the brainfart came from, but here we are.Description
Fixes hanging screen during NewGRF Scans.
As bonus, made the code look more similar between those two windows .. for some reason someone decided to go the completely different direction for the second :P
Additionally, just because I am too lazy to make an extra PR out of it, run the CI against LibSDL2 and LibSDL1.2.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.