Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRF scanner progress updating no longer works due to _realtime_tick changes #8697

Closed
JGRennison opened this issue Feb 19, 2021 · 2 comments · Fixed by #8699
Closed

GRF scanner progress updating no longer works due to _realtime_tick changes #8697

JGRennison opened this issue Feb 19, 2021 · 2 comments · Fixed by #8699
Labels
regression It used to work, and now it's broken.

Comments

@JGRennison
Copy link
Contributor

Version of OpenTTD

Since d437445

Checked on SDL2 and Win32/WINE

It appears that DrawDirtyBlocks/HasModalProgress releases the locks so that the scanner thread can progress, but as _realtime_tick is no longer updated, the scanner thread will not release the locks to allow DrawDirtyBlocks/HasModalProgress to re-acquire them until all scanning has completed.

Expected result

NewGRF scanner window periodically updates at startup.

Actual result

NewGRF scanner does not update, the entire window is frozen until the scan completes.

Steps to reproduce

Run the game (preferably with lots of NewGRFs).
@glx22
Copy link
Contributor

glx22 commented Feb 19, 2021

I can confirm the issue with my 1305 NewGRFs :)

@glx22 glx22 added the regression It used to work, and now it's broken. label Feb 19, 2021
@TrueBrain TrueBrain mentioned this issue Feb 19, 2021
Merged
@TrueBrain
Copy link
Member

"oops".

Sorry :)

Happy you spotted this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression It used to work, and now it's broken.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix d437445c: also use std::chrono for the GRFFileScanner modal window TrueBrain/OpenTTD
3 participants
@TrueBrain @glx22 @JGRennison