Add *.bin filter to Import dialog #307
Merged
+86
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
*.bin
filter to the Import File dialog for Agilent, Keysight and Rigol multi-channel binary waveform capture files.DoImportCSV()
andDoImportBIN()
are very similar and could probably be refactored down intoDoFileImport()
. I didn't have any CSVs to test with so I focused on getting the BIN import working on its own.See related PR ngscopeclient/scopehal#396 for BIN file parser.