Avoid fragmentainer overflow from children of monolithic content. #27701
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if the border box of a monolithic element can fit in the
current fragmentainer isn't enough. Children may overflow its border
box, and it's this size that we need to consider when determining
whether a monolithic element can fit in the current fragmentainer, or if
we have to push it to the next one.
Had to add a work-around to
fast/multicol/vertical-lr/balancing/balance-unbreakable.html to prevent
the (monolithic) IMG element (with alt text) in the test from messing
up. The broken image symbol got incorrectly aligned and therefore
incorrectly contributed to overflow. Reported crbug.com/1178743 for
this. Use a real image as a work-around. My first attempt was to switch
the IMG to writing-mode:horizontal-tb, but that messes up legacy column
balancing. Oh well...
Bug: 1178742
Change-Id: Iffbe55d53f32003ae58b574bb6a38745bb92d42e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2696632
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#858109}