Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest fasm setup.py no longer works as a git+https URL #60

Closed
litghost opened this issue Feb 19, 2021 · 5 comments · Fixed by #62
Closed

Latest fasm setup.py no longer works as a git+https URL #60

litghost opened this issue Feb 19, 2021 · 5 comments · Fixed by #62
Assignees
@mithro
Labels
done invalid This doesn't seem right

Comments

@litghost
Copy link
Collaborator

litghost commented Feb 19, 2021 •
edited

https://github.com/SymbiFlow/symbiflow-xc-fasm2bels/blob/master/requirements.txt#L11

Replication:

python3 -mvenv env
source env/bin/activate
pip install --upgrade wheel
pip install --upgrade pip
pip install git+https://github.com/SymbiFlow/fasm.git#egg=fasm

Error:

  Building wheel for fasm (PEP 517) ... done
  Created wheel for fasm: filename=fasm-UNKNOWN-cp38-cp38-linux_x86_64.whl size=642389 sha256=a91aab3db5b998176a45237691fc079f7cba1b9c508a202b0175fd1cf907c17f
  Stored in directory: /tmp/pip-ephem-wheel-cache-n9jo50br/wheels/a4/27/09/7e90d3d4e2b629aa65ee58ad49638067e48f727e1d0cc7897c
  WARNING: Built wheel for fasm is invalid: Metadata 1.2 mandates PEP 440 version, but 'UNKNOWN' is not
Failed to build fasm
ERROR: Could not build wheels for fasm which use PEP 517 and cannot be installed directly
@issuelabeler issuelabeler bot added done invalid This doesn't seem right labels Feb 19, 2021
@litghost
Copy link
Collaborator Author

Workaround:

pip install --no-use-pep517 git+https://github.com/SymbiFlow/fasm.git#egg=fasm

Results in:

Collecting fasm
  Cloning https://github.com/SymbiFlow/fasm.git to /tmp/pip-install-6c4dhdmb/fasm_d95d1bb5c7104c98b2df1a300b825a5d
  Running command git clone -q https://github.com/SymbiFlow/fasm.git /tmp/pip-install-6c4dhdmb/fasm_d95d1bb5c7104c98b2df1a300b825a5d
  Running command git submodule update --init --recursive -q
Collecting textx
  Using cached textX-2.3.0-py2.py3-none-any.whl (72 kB)
Collecting Arpeggio>=1.9.0
  Using cached Arpeggio-1.10.1-py2.py3-none-any.whl (54 kB)
Building wheels for collected packages: fasm
  Building wheel for fasm (setup.py) ... |
done
  Created wheel for fasm: filename=fasm-UNKNOWN-cp38-cp38-linux_x86_64.whl size=642392 sha256=38954b95fcef9fe03e4f100284785df24150f4b5ab3bfd3132c5c741f4c7561f
  Stored in directory: /tmp/pip-ephem-wheel-cache-jucev7v4/wheels/a4/27/09/7e90d3d4e2b629aa65ee58ad49638067e48f727e1d0cc7897c
  WARNING: Built wheel for fasm is invalid: Metadata 1.2 mandates PEP 440 version, but 'UNKNOWN' is not
Failed to build fasm
Installing collected packages: Arpeggio, textx, fasm
    Running setup.py install for fasm ... \^|^[[5done
  DEPRECATION: fasm was installed using the legacy 'setup.py install' method, because a wheel could not be built for it. A possible replacement is to fix the wheel build issue reported above. You can find discussion regarding this at https://github.com/pypa/pip/issues/8368.
Successfully installed Arpeggio-1.10.1 fasm-UNKNOWN textx-2.3.0

@litghost
Copy link
Collaborator Author

Example of the affect: chipsalliance/f4pga-xc-fasm2bels#47

@Mattia9875
Copy link

Please add the change to the requirements.txt in the toolchain installantion process over symbiflow-examples

@Mattia9875 Mattia9875 mentioned this issue Feb 19, 2021
Open
mithro added a commit to mithro/fasm that referenced this issue Feb 19, 2021
@mithro
Run update_version.py script if version.py not found.
585b927 
Fixes chipsalliance#60

Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@mithro
Copy link
Contributor

mithro commented Feb 19, 2021

Working on this now.

mithro added a commit to mithro/fasm that referenced this issue Feb 19, 2021
@mithro
Run update_version.py script if version.py not found.
acf3994 
Fixes chipsalliance#60

Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
mithro added a commit to mithro/fasm that referenced this issue Feb 19, 2021
@mithro
Run update_version.py script if version.py not found.
a52239c 
Fixes chipsalliance#60

Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
mithro added a commit to mithro/fasm that referenced this issue Feb 19, 2021
@mithro
Run update_version.py script if version is 'UNKNOWN'.
f078669 
Fixes chipsalliance#60

Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@mithro mithro mentioned this issue Feb 19, 2021
Merged
mithro added a commit to mithro/fasm that referenced this issue Feb 19, 2021
@mithro
Run update_version.py script if version is 'UNKNOWN'.
6137b3b 
Fixes chipsalliance#60

Signed-off-by: Tim 'mithro' Ansell <me@mith.ro>
@mithro
Copy link
Contributor

mithro commented Feb 19, 2021

Should be fixed soon by #62

@charkster charkster mentioned this issue Feb 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mithro mithro

Labels
done invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix install fasm directly from GitHub mithro/fasm
3 participants
@mithro @litghost @Mattia9875