[advance-override] Implement the second percentage parameter #27691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 19, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2706243
branch
3 times, most recently
from
9d9c43e
to
5297082
Compare
For upright characters in vertical text layout, the advance of a glyph is its height instead of width, and therefore we may want a different scale factor for overriding the advance height instead of width. Hence, following the spec revision [1], this patch implements the second parameter for use in upright glyphs in vertical text layout. [1] w3c/csswg-drafts#6020 Bug: 1137633 Change-Id: I277d84711b9478f21ba3bd1b3aa987196fb0499e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706243 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#856529}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2706243
branch
from
5297082
to
803ffad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For upright characters in vertical text layout, the advance of a glyph
is its height instead of width, and therefore we may want a different
scale factor for overriding the advance height instead of width.
Hence, following the spec revision [1], this patch implements the
second parameter for use in upright glyphs in vertical text layout.
[1] w3c/csswg-drafts#6020
Bug: 1137633
Change-Id: I277d84711b9478f21ba3bd1b3aa987196fb0499e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2706243
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856529}