Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start/stop icon in vehicle status bar is off-center vertically #8770

Closed
James103 opened this issue Feb 28, 2021 · 2 comments
Closed

Start/stop icon in vehicle status bar is off-center vertically #8770

James103 opened this issue Feb 28, 2021 · 2 comments
Labels
bug Something isn't working priority: low This issue should be fixed but has either a low impact or is en edge-case

Comments

@James103
Copy link
Contributor

Version of OpenTTD

1.11.0-beta2

Expected result

The start/stop icon in the vehicle status is centered vertically properly with the text, as shown here:
image
(1 pixel movement upwards is sufficient to cover both the stopped flag and the running flag)

Actual result

The start/stop icon in the vehicle status is not fully centered properly on the vertical axis despite the works of #8602, as shown here:
image

Steps to reproduce

  1. Start a new map.
  2. Build a depot, and buy any vehicle.
  3. In the vehicle window, look at the statusbar. Notice that the icon is off-center vertically.
  4. Start the vehicle (or stop it).
  5. Notice that the icon is still off-center.
@LordAro
Copy link
Member

LordAro commented Feb 28, 2021

Quad zoom to make it a little more obvious:

image

@TrueBrain TrueBrain added bug Something isn't working priority: low This issue should be fixed but has either a low impact or is en edge-case labels Apr 10, 2021
@PeterN
Copy link
Member

PeterN commented Nov 14, 2022

The sprite is centred, it just has offsets that mean the centring places it lower. However with 10114 a lot of sprites are now drawn ignore offsets, so this could be done here too.

PeterN added a commit to PeterN/OpenTTD that referenced this issue Nov 17, 2022
The icon is now centred within its scaled bounding box, which intentionally
leaves a little space around the icon when not at 1/2/4x scale.
@PeterN PeterN closed this as completed in 60404c3 Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: low This issue should be fixed but has either a low impact or is en edge-case
Projects
None yet
Development

No branches or pull requests

4 participants