Unlimit framerate window and fix pause behaviour #8772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueBrain
approved these changes
Feb 28, 2021
|
How did you get to 973,000 ticks per second for game loop? Which CPU did you achieve that tickrate on? (For comparison, an i5-9400F running at a boost of 3.8 GHz gets 400,000 ticks per second) |
|
i5-6600k, 64x64 completely water map, full animation/details disabled, maximum zoom in a corner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Framerate window maxes out at 9999 fps. Game can (fairly trivially) exceed that now. Useful/fun to display the actual framerate
While paused, framerate window would display the last (stale) data, rather than zero-values
Description
Removes limit on framerate window
Changes behaviour of window while game is paused:
Before:
After:
Limitations
Might consider adding
SetInactivetoPausedto be a hack.Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.